Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… #7520

Closed
wants to merge 1 commit into from

Conversation

Catddly
Copy link
Contributor

@Catddly Catddly commented Feb 6, 2023

Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos!
It only implement GetTypeRegistration for Vec, but not for VecDeque.
This will cause serialization and deserialization failure.

… object, it only implements for Vec<T>, but not
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, great catch!

@MrGVSV MrGVSV added C-Bug An unexpected or incorrect behavior A-Reflection Runtime information about types labels Feb 6, 2023
@MrGVSV MrGVSV added this to the 0.10 milestone Feb 6, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2023
@mockersf
Copy link
Member

mockersf commented Feb 6, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
#7520)

Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos!
It only implement GetTypeRegistration for Vec<T>, but not for VecDeque<T>.
This will cause serialization and deserialization failure.
@bors bors bot changed the title fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… [Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants